react-native-fingerprint-scanner
react-native-fingerprint-scanner copied to clipboard
hieuvp
Use LAPolicyDeviceOwnerAuthentication when fallback is enabled
'Enter Password' doesn't working. It because the policy should be LAPolicyDeviceOwnerAuthentication when fallback is enabled.
Thanks @azgron - to clarify, what's the behavior you're expecting to see when "Enter Password" is used?
To clarify - the fallback doesn't bring up the system fallback (e.g. password), but the app's fallback.
@phillbaker Hah, I didn't understand it. I thought it should fallback to device passcode :)
Do you think the passcode could be useful for the library?
Do you think the passcode could be useful for the library?
I don't understand the question - do you mean this PR? Can you explain a bit?
Yes.
This pull request was because in the beginning I thought that the functionality of clicking 'Enter Password' button, should present the 'ios passcode screen' (system fallback):
Now, I do understand that the application should implement it's own functionality of fallback.
To clarify - the fallback doesn't bring up the system fallback (e.g. password), but the app's fallback.
Do you think this library should support system fallback as default? If yes, How do you think it should be implemented?
Do you think this library should support system fallback as default? If yes, How do you think it should be implemented?
As I understand it, the system password is not available for use by applications - it's only available to the device itself. Are there any docs for exposing the system password for use in apps?
@phillbaker
My changes in this pull request do this functionality (Read about LAPolicyDeviceOwnerAuthentication vs LAPolicyDeviceOwnerAuthenticationWithBiometrics)
It brings the passcode device screen.
Please check my changes and run it locally (Try to press ‘Enter passcode’).
I have attached a gif:
@phillbaker
What do you think? Would you like to change the way I implemented the system fallback?
A few thoughts:
- looks like this is only available post iOS 9, need to double check what iOS versions react native still supports
- is this cross compatible with Android?
On Sun, May 26, 2019 at 2:59 AM azgron [email protected] wrote:
@phillbaker https://github.com/phillbaker
What do you think? Would you like to change the way I implemented the system fallback?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hieuvp/react-native-fingerprint-scanner/pull/82?email_source=notifications&email_token=AAAXCKMYVNLHRXWSEWWPLYLPXIYM5A5CNFSM4HN4FEY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWH7VHA#issuecomment-495975068, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAXCKKGK2MOAZU4OSKXJ33PXIYM5ANCNFSM4HN4FEYQ .
@azgron I really want to implement device password fallback in my app. Thanks much for this PR. Is this pr be merged?
There were questions above @ReemaVinodGangdev
-
only supports iOS10+, what does react-native support? iOS moved to 10+ - https://github.com/facebook/react-native/blob/master/template/ios/Podfile#L4 - as of react-native 0.63 which is release candidate now but will release soon. It seems this may need IFDEFs for iOS9 so it is safe on them as the old react-native's should be supported for more than "the upcoming release candidate has it"
-
is it cross-compatible with android - no idea on that one, and @azgron did not answer
If you @ReemaVinodGangdev were at least able to pull the PR and test it to report success that would probably also help the process. Usually PRs need a few people to collaborate in order to review, pull+test+report-success etc, so if you need it, help push it forward and that's how it gets done :-)
is it cross-compatible with android - no idea on that one, and @azgron did not answer
iOS only. Given that only 1 file was modified.
If you @ReemaVinodGangdev were at least able to pull the PR and test it to report success that would probably also help the process. Usually PRs need a few people to collaborate in order to review, pull+test+report-success etc, so if you need it, help push it forward and that's how it gets done :-)
I tested it. Worked great.
