react-native-fingerprint-scanner icon indicating copy to clipboard operation
react-native-fingerprint-scanner copied to clipboard

Face Scan in Android

Open zhuminjunivan opened this issue 3 years ago • 5 comments

if PromptInfo set setConfirmationRequired(fasle),face scan error dialog will show two negativeButton;

As shown : IMG20211110120238

set setConfirmationRequired(true) no matter

zhuminjunivan avatar Nov 10 '21 04:11 zhuminjunivan

It sounds like you are here? https://github.com/hieuvp/react-native-fingerprint-scanner/blob/31f160f6437415258a6204ca8481612b314e41f8/android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java?#L130

What if you remove the next line so there is no cancel text? Is this device specific? Are there other reports of this?

It looks like the package ships with this configuration to start, surprising if it is not listed in the issues then, which makes me think maybe device specific :thinking:

mikehardy avatar Nov 10 '21 13:11 mikehardy

It sounds like you are here? https://github.com/hieuvp/react-native-fingerprint-scanner/blob/31f160f6437415258a6204ca8481612b314e41f8/android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java?#L130

What if you remove the next line so there is no cancel text? Is this device specific? Are there other reports of this?

It looks like the package ships with this configuration to start, surprising if it is not listed in the issues then, which makes me think maybe device specific 🤔

Device : Realme Q3, Android 11

zhuminjunivan avatar Nov 11 '21 00:11 zhuminjunivan

Maybe this is a system bug if I setConfirmationRequired(true),face sacn successed need to confirm; if setDeviceCredentialAllowed(true) and not setNegativeButtonText also ok;although user need to enter password,but don't affect the operation。 so advice open parameter to rn,let developer choose; Thanks

zhuminjunivan avatar Nov 11 '21 02:11 zhuminjunivan

I am no authority in this module, but in general that seems like a reasonable thing if you wanted to make a pull request with it

mikehardy avatar Nov 11 '21 03:11 mikehardy

I am no authority in this module, but in general that seems like a reasonable thing if you wanted to make a pull request with it

never mind,i change it locally

zhuminjunivan avatar Nov 11 '21 03:11 zhuminjunivan