license-gradle-plugin icon indicating copy to clipboard operation
license-gradle-plugin copied to clipboard

Support for new line after header license

Open rnavarropiris opened this issue 10 years ago • 3 comments

Mapping a new file extension to an existing style is possible, but no option to add a new style is given (or if so, it is not documented in the README.md file)

rnavarropiris avatar Feb 17 '15 15:02 rnavarropiris

Actually, the only thing that I actually need is to add a new line after the header as defined in this pull request: https://github.com/hierynomus/license-gradle-plugin/pull/55

Integrating that feature would be enough for my use case (compliance with Google Java Style )

rnavarropiris avatar Feb 17 '15 15:02 rnavarropiris

Hi Ruben,

As you see in the discussion of the #55, the implementation there was suboptimal at best. Also there were additional troubles with verification whether the license was correctly applied. If you have a better PR, I'll be more than happy to incorporate it.

hierynomus avatar Feb 18 '15 15:02 hierynomus

Instead of adding parameter insertNewline, what about supporting mycila headerDefinitions which gives more flexibility ? This is for example used by the Guice project:

  • https://github.com/google/guice/blob/master/lib/build/header-definitions.xml
  • https://github.com/google/guice/blob/master/pom.xml#L227-L229

simonbrandhof avatar Mar 12 '17 11:03 simonbrandhof