Slyghtning

Results 81 comments of Slyghtning

@guggero, I think I addressed all your nits. Additionally [I added a test case](https://github.com/lightningnetwork/lnd/pull/6903/commits/f6319df4aa9e2e66e4cc79fb0070d9a0ece81673#diff-583407cd98e4e423efd8a6afe4acb5b67395da6ae79927b11f9e3b989f822313R144) to check for skipping the anchor reserve in case we start the `--fundmax` flow for a...

> Given the size of the PR, it may be useful to explain the motivation in a bit more detail. > > The PR description explains that there is no...

> Thanks for extending the description. As to why users want this, I suppose it's to put the maximum capital to work in the opened channel and not leave any...

> Did an initial pass just to start loading the context for this diff. Great work @hieblmi! For now I have just left some questions just to help with my...

😬 now requested review from @ellemouton but @guggero's review request disappeard 😅

One more note, I realized that in my last commits I forgot a check from the original PR in `cmd_open_channel.go` which I added. It's here: https://github.com/lightningnetwork/lnd/pull/6903/commits/efe3d95782639899af172df7c5378e7afd824519#diff-81f87a9144ebe01ee1916dad1a5d76287e7c76ced4fd2ae553a8e9ea5a17c190R363

Might be a little simplified once this is merged to lnd: https://github.com/lightningnetwork/lnd/pull/7001

I am working on this and should have a PR ready soon.

The discussion was started here https://github.com/edouardparis/lntop/issues/68 but hasn't gained traction so far. In this PR I want to introduce a simple view of the forwarding history without the need for...

> I am working on this and should have a PR ready soon. I got the basic functionality working locally but I would like to wait until https://github.com/lightningnetwork/lnd/pull/7083 makes it...