materialistic icon indicating copy to clipboard operation
materialistic copied to clipboard

Fix article sharing

Open WillieCubed opened this issue 7 years ago • 5 comments

Fixes #917, #930, #985 by using a proper share picker.

WillieCubed avatar Nov 19 '17 08:11 WillieCubed

Does this fix work? Why hasn't it been merged? Such a painful bug, as I use sharing all the time; causing me to consider leaving to another reader.

pretzelwagon avatar Feb 27 '18 03:02 pretzelwagon

test failures simply need to be updated to change the expected result to follow this change...

    java.lang.AssertionError: Expected action <android.intent.action.SEND> but was
<android.intent.action.CHOOSER>.

tamsky avatar Mar 10 '18 01:03 tamsky

Hey all sorry for late reply, let me review this. I think I have been going back and forth on this chooser vs non chooser a few times. If I remember correctly the chooser doesn't offer the options Just once/Always, and people complain about that, while non-chooser (relying on platform chooser) has different behavior on Samsung devices.

hidroh avatar Mar 10 '18 07:03 hidroh

Thank you so much for this @WillieCubed! I recently had need to make an adjustment to another OSS app I use, and thought I'd try to tackle the share menu in Materialistic while I was at it (it's the only app I use with the old-style share menu so I miss out on direct share and pinned apps). Thanks to you the process took me 10 minutes from start to finish.

@hidroh Thank you of course for Materialistic! If you want to consider merging this PR I'm happy to help with testing or whatever else a non-android-dev might be useful for. I have access to a OnePlus 3t running Lineage and a OnePlus 5 running stock Oxygen.

Thanks again guys!

garymoon avatar Feb 19 '19 14:02 garymoon

Bump for @hidroh

WillieCubed avatar Jan 28 '23 21:01 WillieCubed