cucumber-api icon indicating copy to clipboard operation
cucumber-api copied to clipboard

Published 20 hours ago • verified publisher icon hidroh

Update steps.rb

Open gokcesurenkok opened this issue 7 years ago • 5 comments

gokcesurenkok avatar Jan 27 '17 19:01 gokcesurenkok

Seems like your PR introduces a dependency that requires Ruby >= 2.0 which is more than what currently supported.

hidroh avatar Jan 28 '17 03:01 hidroh

@hidroh I don't think so, I think that the versions have simply changed underneath everything and now bundler is pulling in addressable 2.5 which requires ruby >= 2.0.0.

I have created a PR to fix this. If that gets merged then the other outstanding two PRs can be rebased off of it.

wiggly avatar Mar 02 '17 19:03 wiggly

@gokcesurenkok may be a little explanation of what you're trying to do here?

hidroh avatar Mar 03 '17 08:03 hidroh

Sorry just saw #8, let me read thru it.

hidroh avatar Mar 03 '17 08:03 hidroh

How about using JSON.dump(JSON.parse) for consistency as in https://github.com/gokcesurenkok/cucumber-api/blob/eb76d333a092f52648e6a9b157a08b38dcf7ee9f/lib/cucumber-api/steps.rb#L60?

hidroh avatar Mar 03 '17 08:03 hidroh