hiboot icon indicating copy to clipboard operation
hiboot copied to clipboard

update Iris to version 12

Open kataras opened this issue 4 years ago • 2 comments

This commit contains all the necessary code and minor improvements to work with the latest Iris (v12.0.1) and Go 1.13. @john-deng ^

kataras avatar Oct 29 '19 16:10 kataras

@kataras Thanks for your PR, iris makes the coding of hiboot much easier, however, we used previous on production, some of the iris features such as websocket are not compatible with the new version, it may take some time to fix this kind of issues. Also Travis CI build failed, please help to fix it as well.

john-deng avatar Oct 30 '19 05:10 john-deng

Hello @john-deng, the websocket changed but as I've seen you copy-pasted the previous Iris websocket code right in this project at /pkg/starter/websocket folder so I assume you don't have to upgrade them if you don't want to. Some of the tests are failing but this is not because of the update, this will happen if you clone the project to a new machine and try to go test -v ./... as well (some of your deps are not compatible anymore with your app), I've fixed some of them with go modules but you can investigate more and do the rest as well.

kataras avatar Oct 31 '19 14:10 kataras