simsopt icon indicating copy to clipboard operation
simsopt copied to clipboard

CurveCWSFourier Class for CWS bounded coil optimization

Open joaopedrobiu6 opened this issue 1 year ago • 4 comments

This PR enables SIMSOPT to create coil curves on a specified coil winding surface. For this purpose, the following changes are implemented.

  1. New class CurveCWSFourier allows the creation of a coil curve given the dofs of a surface.
  2. CurveCWS inherits from the Curve class.
  3. Allows the optimization of curves bounded to the CWS without changing the winding surface.

Need to add unit tests. (João Biu, student of Rogério Jorge)

joaopedrobiu6 avatar Jun 05 '24 17:06 joaopedrobiu6

@lankef Frank, tagging you here in case you haven't seen this pull request and its helpful for you

akaptano avatar Jun 14 '24 18:06 akaptano

Thank you, I didn't notice. I'll check if it solves the gradient issue. There doesn't seem to be any change to the flux objective's implementation though?

Frank


From: Alan Kaptanoglu @.> Sent: Friday, June 14, 2024 14:44 To: hiddenSymmetries/simsopt @.> Cc: Frank Fu @.>; Mention @.> Subject: Re: [hiddenSymmetries/simsopt] CurveCWSFourier Class for CWS bounded coil optimization (PR #420)

@lankefhttps://github.com/lankef Frank, tagging you here in case you haven't seen this pull request and its helpful for you

— Reply to this email directly, view it on GitHubhttps://github.com/hiddenSymmetries/simsopt/pull/420#issuecomment-2168572978, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADDUGMR73V2UC4SUKJVX7ULZHM2X3AVCNFSM6AAAAABI3EVBYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGU3TEOJXHA. You are receiving this because you were mentioned.Message ID: @.***>

lankef avatar Jun 29 '24 02:06 lankef

@joaopedrobiu6 is this PR still in progress or should we close?

mishapadidar avatar May 13 '25 15:05 mishapadidar

@mishapadidar, me and @rogeriojorge I are solving some merge conflicts between our branch and the master and we'll probably open a PR instead of just a draft

joaopedrobiu6 avatar May 13 '25 16:05 joaopedrobiu6