CurveCWSFourier Class for CWS bounded coil optimization
This PR enables SIMSOPT to create coil curves on a specified coil winding surface. For this purpose, the following changes are implemented.
- New class CurveCWSFourier allows the creation of a coil curve given the dofs of a surface.
- CurveCWS inherits from the Curve class.
- Allows the optimization of curves bounded to the CWS without changing the winding surface.
Need to add unit tests. (João Biu, student of Rogério Jorge)
@lankef Frank, tagging you here in case you haven't seen this pull request and its helpful for you
Thank you, I didn't notice. I'll check if it solves the gradient issue. There doesn't seem to be any change to the flux objective's implementation though?
Frank
From: Alan Kaptanoglu @.> Sent: Friday, June 14, 2024 14:44 To: hiddenSymmetries/simsopt @.> Cc: Frank Fu @.>; Mention @.> Subject: Re: [hiddenSymmetries/simsopt] CurveCWSFourier Class for CWS bounded coil optimization (PR #420)
@lankefhttps://github.com/lankef Frank, tagging you here in case you haven't seen this pull request and its helpful for you
— Reply to this email directly, view it on GitHubhttps://github.com/hiddenSymmetries/simsopt/pull/420#issuecomment-2168572978, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADDUGMR73V2UC4SUKJVX7ULZHM2X3AVCNFSM6AAAAABI3EVBYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGU3TEOJXHA. You are receiving this because you were mentioned.Message ID: @.***>
@joaopedrobiu6 is this PR still in progress or should we close?
@mishapadidar, me and @rogeriojorge I are solving some merge conflicts between our branch and the master and we'll probably open a PR instead of just a draft