cronjobber icon indicating copy to clipboard operation
cronjobber copied to clipboard

Published 20 hours ago • verified publisher icon hiddeco

Periodic rebase on upstream CronJob controller

Open mterron opened this issue 5 years ago • 7 comments

There's been some changes to the Kubernetes CronJob controller since v1.13.3

It'd be good to track upstream and periodically sync CronJobber to the upstream CronJob version to avoid diverging too much form the defaults.

mterron avatar May 16 '19 22:05 mterron

@hiddeco did you have a chance to look into this? It'd be good from a project health perspective to track upstream.

mterron avatar Aug 18 '19 22:08 mterron

@mterron did not look into this yet as I am pretty occupied at the moment and the amount of spare time I have is limited (at least until the end of September).

The idea is however great, and I agree it would be good from a project health perspective. If someone has or finds time to attempt a rebase and report back eventual issues, I will be happy to put some of my time into thinking how we could deal with those. Fully working PRs are also more than welcome.

hiddeco avatar Aug 19 '19 18:08 hiddeco

Any chance you can take a look? I think K8s has diverged too much for me to be comfortable providing a PR, sorry.

mterron avatar Feb 26 '20 19:02 mterron

Thanks for checking in on this.

I have a general idea on how this could be pulled off in an automated way, it does however mean that much of the work has to be re-done to get the structure right. However with KubeCon EU ahead, and other projects that take up most of my time at the moment, I am not sure when I will get to this -- but I still will eventually.

Have to mention that as long as this boots, reacts to created TZCronJobs and spawns Jobs on the latest Kubernetes versions, there shouldn't be too much to worry about.

hiddeco avatar Feb 27 '20 22:02 hiddeco

HI, We have been using Cronjobber for a while at CloudCasa (https://cloudcasa.io/) and felt the same need to rebase the project on latest native cronjob controller. We are able to take the latest cronjob code and apply the patch to add time zone functionality. It is working well in our internal tests and we will be happy to submit the changes as PR here. It will be great if others can try it as well and give feedback.

draghuram avatar Mar 04 '22 17:03 draghuram

Thanks for your interest and time @draghuram, feel absolutely free to open a PR. It may take some time to properly get back to you, but I will make sure things get landed.

hiddeco avatar Mar 04 '22 20:03 hiddeco

Thanks @hiddeco. We will create the PR in a day or two and we will take it from there.

draghuram avatar Mar 07 '22 19:03 draghuram