hicetnunc icon indicating copy to clipboard operation
hicetnunc copied to clipboard

Filter banned wallets from objkt collectors tab.

Open neelts opened this issue 4 years ago • 5 comments

This will make life harder for the bots stealing and selling free OBJKT's

neelts avatar Apr 27 '21 10:04 neelts

Possibly a better idea might be to remove the Collect button, and add a note to the wallet id eg tz1... (banned) to the owner-swap component.

That way it's more transparent to the creator where all their editions went, and also prevents users buying from banned users.

skenaja avatar Apr 27 '21 12:04 skenaja

Possibly a better idea might be to remove the Collect button, and add a note to the wallet id eg tz1... (banned) to the owner-swap component.

That way it's more transparent to the creator where all their editions went, and also prevents users buying from banned users.

https://github.com/hicetnunc2000/hicetnunc/pull/598

neelts avatar Apr 27 '21 12:04 neelts

This should probably be done on the API. I'm not sure adding this amount of logic to the frontend is a good idea. Can you do a PR on the API repo?

andrevenancio avatar May 07 '21 02:05 andrevenancio

This should probably be done on the API. I'm not sure adding this amount of logic to the frontend is a good idea. Can you do a PR on the API repo?

I can, but have you checked this one #598? So which one would be better to do?

neelts avatar May 07 '21 12:05 neelts

I prefer to leave a trace of banned objkts so the collector can decide to burn them.

djangobits avatar Jun 03 '21 20:06 djangobits