hicetnunc icon indicating copy to clipboard operation
hicetnunc copied to clipboard

Button specificity + Curate button feedback

Open tarwin opened this issue 3 years ago • 3 comments

refactor: made buttons more specific to function, not needing to be wrapped by <Button>

refactor: changed <Curate> button to <ActionButton>

feat: added a <CurateButton> specifically for the hDAO voting button which gives feedback (<Loader>) while waiting for wallet

tarwin avatar Apr 05 '21 23:04 tarwin

I dont mind this change. it requires you to have the same props duplicated on each button. I wonder if we should just destructure props into <Button..

Example:

export const Primary = (props) => {
....
return <Button {...props}>....</Button>

Or... probably better use <Button primary /> <Button secondary />

What do you think?

andrevenancio avatar Apr 06 '21 02:04 andrevenancio

The <Button primary /> makes sense to me. That said, should we also move things like the <Curate /> button their own components? Was just trying to not screw with the codebase too much to start with.

tarwin avatar Apr 06 '21 05:04 tarwin

I think this would fix: https://github.com/hicetnunc2000/hicetnunc/pull/415

peterschmidler avatar Jun 18 '21 00:06 peterschmidler