hicetnunc icon indicating copy to clipboard operation
hicetnunc copied to clipboard

not able to mint markdown (md) objkts

Open fraguada opened this issue 2 years ago • 3 comments

Describe the bug md files seem to be supported, but it seems they cannot be minted as I get the message that the file format is invalid. I guess from this line: https://github.com/hicetnunc2000/hicetnunc/blob/main/src/pages/mint/index.js#L81 The file I was minting was the objkt-swap README.md, as a test.

The ALLOWED_MIMETYPES defined in constants.js has the following for md: MD : 'text/plain'

Trying to mint a .txt file of the same results in a blank page after hitting mint with multiple errors in the console: image

UPDATE: submitted a PR to constants.js to fix the mimetype: https://github.com/hicetnunc2000/hicetnunc/pull/1297

Screenshots Preview: Screenshot 2021-10-15 at 13 20 28 After pressing mint: Screenshot 2021-10-15 at 13 20 07

To Reproduce Steps to reproduce the behavior:

  1. Go to the mint page and fill out some data
  2. Upload a markdown, md file
  3. Preview
  4. Hit mint

Expected behavior Expected that if md files are supported, one should be able to mint them.

Desktop (please complete the following information):

  • OS: macos
  • Browser: Firefox
  • Version: 93.0

fraguada avatar Oct 15 '21 11:10 fraguada

This has been merged!

melMass avatar Apr 19 '22 09:04 melMass

really? this is a really common bug while uploading files, where mimetypes are not recognisable

crzypatchwork avatar Apr 19 '22 22:04 crzypatchwork

Hmmm I'm not sure now 😆. I will check it when I'm home, but I think it was addressed by Kyle a few weeks ago.

melMass avatar Apr 20 '22 09:04 melMass