asynq icon indicating copy to clipboard operation
asynq copied to clipboard

Archived tasks that are trimmed from the set are deleted

Open Harrison-Miller opened this issue 1 year ago • 8 comments

Solves the issue outlined in: https://github.com/hibiken/asynq/issues/730

You can confirm the test case/fix is working by deleting lines: 852/860 in rdb.go of the fix branch to observe the old failure.

Harrison-Miller avatar Sep 19 '23 19:09 Harrison-Miller

Possibly related to

Issues:

  • #329
  • #441
  • #711

PRs:

  • #517

kamikazechaser avatar Sep 20 '23 06:09 kamikazechaser

Depends on #441

kamikazechaser avatar Jan 28 '24 08:01 kamikazechaser

When will this pull request be merged?

ray2011 avatar May 09 '24 12:05 ray2011

@ray2011 It (softly) depends on the #534.

kamikazechaser avatar May 10 '24 09:05 kamikazechaser

I will try and work on the suggestion in the next few weeks.

Harrison-Miller avatar May 18 '24 17:05 Harrison-Miller

@kamikazechaser nvm it took 3 seconds to change, confirmed the tests I added still pass. Anything else you need changed?

Harrison-Miller avatar May 18 '24 23:05 Harrison-Miller

Anything else you need changed?

No, Thanks!

kamikazechaser avatar May 20 '24 14:05 kamikazechaser

When will 0.25.0 be published? 9999 archived task made me crazy.

cobain avatar Aug 04 '24 15:08 cobain