asynq icon indicating copy to clipboard operation
asynq copied to clipboard

feat: add publish and getpubsub for streaming

Open FogDong opened this issue 1 year ago • 2 comments

Fix #437

This PR adds publish and getPubSub so that users can use publish to stream messages and use getPubSub to receive.

FogDong avatar Sep 07 '23 07:09 FogDong

Thanks for this. From what I can see this is a feature to track tasks via Redis pub/sub. An alternative to ResultWriter.Write.

However this is not really a fix for #437 and looks very unrelated to it (capturing Redis commands). Could you create a new issue and maybe get feedback on it? Nevertheless, this looks like a good feature to have.

kamikazechaser avatar Sep 07 '23 10:09 kamikazechaser

Codecov Report

Merging #736 (40df09c) into master (6b98c0b) will decrease coverage by 0.25%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   68.37%   68.12%   -0.25%     
==========================================
  Files          27       27              
  Lines        3836     3850      +14     
==========================================
  Hits         2623     2623              
- Misses        929      943      +14     
  Partials      284      284              
Files Changed Coverage Δ
asynq.go 66.66% <0.00%> (-2.13%) :arrow_down:
inspector.go 60.27% <0.00%> (-0.43%) :arrow_down:
internal/base/base.go 70.18% <ø> (ø)
internal/rdb/rdb.go 73.36% <0.00%> (-0.92%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 07 '23 10:09 codecov[bot]