hibernate-validator icon indicating copy to clipboard operation
hibernate-validator copied to clipboard

Published 20 hours ago • verified publisher icon hibernate

HV-1973 - Bitcoin address validator

Open jyoshiriro opened this issue 1 year ago • 2 comments

Bitcoin address validator.

More translations are still missing. Only english and portuguese have been provided so far.

See https://hibernate.atlassian.net/browse/HV-1973.

jyoshiriro avatar Apr 13 '24 03:04 jyoshiriro

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HV-\d+     ↳ Offending commits: [404f52924896e336506c02b215b6fff131b16ae1]

› This message was automatically generated.

hibernate-github-bot[bot] avatar Apr 15 '24 14:04 hibernate-github-bot[bot]

Hey,

thanks for submitting the pull request with the new constraint. This looks interesting. I've added some suggestions inline. Please also take a look at this post https://in.relation.to/2018/01/04/adding-new-constraint-to-engine/ to see about the additional parts that should be added for a constraint.

I believe I fixed everything that was missing :)

jyoshiriro avatar Apr 15 '24 22:04 jyoshiriro

Thanks! I've squashed the changes in this patch and removed the dependency on the resource bundle from the validator implementation. I'm going to close this PR in favour of https://github.com/hibernate/hibernate-validator/pull/1387 Thanks for all the work you did here!

marko-bekhta avatar Jul 17 '24 14:07 marko-bekhta