hibernate-tools icon indicating copy to clipboard operation
hibernate-tools copied to clipboard
verified publisher icon hibernate

HBX-2956 Use SHA in github actions workflow

Open marko-bekhta opened this issue 1 year ago • 3 comments

https://hibernate.atlassian.net/browse/HBX-2956

I'm not sure about the GabrielBB/xvfb-action since it seems that this one is for running some selenium tests, but I don't think we have those in the repository? (or was there some other reason to install XVFB.. )

marko-bekhta avatar Feb 05 '25 08:02 marko-bekhta

https://hibernate.atlassian.net/browse/HBX-2956

I'm not sure about the GabrielBB/xvfb-action since it seems that this one is for running some selenium tests, but I don't think we have those in the repository? (or was there some other reason to install XVFB.. )

This was used to test the StatisticsBrowser, but this test has been disabled for a long time now: https://github.com/hibernate/hibernate-tools/blob/251b6e653fe0196e68a3d4ccf08d1b54aefef279/test/common/src/main/java/org/hibernate/tool/stat/Statistics/TestCase.java#L46

Not sure if anyone uses this Browser actually...

koentsje avatar Feb 05 '25 09:02 koentsje

Got it 😃, so let's keep it for now, then... maybe the test will get re-enabled at some point 🤞🏻 😃

marko-bekhta avatar Feb 05 '25 09:02 marko-bekhta

hi @koentsje do you think we can merge this one, or maybe you have some questions/concerns? 🙈 😃

marko-bekhta avatar Mar 04 '25 11:03 marko-bekhta

I think we can close this one, as the commit has already been merged.

marko-bekhta avatar Jun 02 '25 06:06 marko-bekhta