hibernate-tools icon indicating copy to clipboard operation
hibernate-tools copied to clipboard

Remove floating point types from types advertised to support precision & scale

Open adferrand opened this issue 1 year ago • 1 comments

Related to HBX-1408

This PR fixes an inconsistency in Java entities generation. Indeed hibernate-tools generate entities whose floating point type fields are annotated with a @Type with scale and precision parameters. However these parameters are not relevant and generate IllegalArgumentException as per https://github.com/hibernate/hibernate-orm/blob/7c58fe9a16eb15e5d1432e4bb3434c89cf214e16/hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java#L5097-L5112.

This PR changes JdbcToHibernateTypeHelper so that typeHasScaleAndPrecision do not advertise these types to support scale and precision.

adferrand avatar Jan 08 '24 08:01 adferrand

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.