hibernate-reactive icon indicating copy to clipboard operation
hibernate-reactive copied to clipboard

MultipleContextTest fails on CI

Open DavideD opened this issue 3 years ago • 5 comments

This test checks that we throw the right exception when session run in the wrong VertxContext.

I cannot figure out why it doesn't fail on CI.

This is the test: MultipleContextTest#persistWithStage

We also need to add tests for the Stateless session (kinda related to #1023)

DavideD avatar Apr 12 '21 09:04 DavideD

FWIW

When I run locally with standard out all 4 tests (Stage & Mutiny) log:

STANDARD_ERROR
    [2021-06-03 15:36:17] WARNING io.vertx.core.impl.VertxImpl 
                               You're already on a Vert.x context, are you sure you want to create a new Vertx instance?

Which I assume would be expected

blafond avatar Jun 03 '21 20:06 blafond

Interesting. We need to figure out why.

gavinking avatar Jun 03 '21 20:06 gavinking

Which I assume would be expected

Yes, that's exactly what the test is supposed to do.

DavideD avatar Jun 04 '21 05:06 DavideD

I suppose we should also check the stateless session, though

DavideD avatar Jun 04 '21 05:06 DavideD

Our assertions don't actually check the contexts but the threads. On CI the test run in the same thread and so the exception is not thrown as expected even if the context associated with the session is different than the execution context.

DavideD avatar Nov 01 '21 10:11 DavideD

I think we can close this issue, the problem has been solved.

DavideD avatar Oct 25 '22 08:10 DavideD