hibernate-reactive icon indicating copy to clipboard operation
hibernate-reactive copied to clipboard

@NamedStoredProcedure and createNamedStoredProcedureQuery()

Open DavideD opened this issue 4 years ago • 8 comments
trafficstars

I don't think it's critical at the moment but I've noticed we don't have an equivalent of createNamedStoredProcedureQuery. @gavinking is it something that we want to have eventually?

DavideD avatar Mar 02 '21 18:03 DavideD

I guess you're going to tell me we need it for the getOutputParameterValue() method?

gavinking avatar Mar 02 '21 18:03 gavinking

I don't see where the Vert.x client even supports output parameters yet.

gavinking avatar Mar 02 '21 18:03 gavinking

To be honest I haven't given it much thought.

I was thinking that a user might want to call a stored procedure that it's defined using the annotation. Considering that the reactive API doesn't have a method to do it, it should be clear enough that we don't support it. Plus, it should work with a native query anyway if they want to call one.

I'm fine closing this issue and create a new one if somebody ask for it or when the Vert.x client offers support for calling stored procedures.

DavideD avatar Mar 02 '21 18:03 DavideD

I was thinking that a user might want to call a stored procedure that it's defined using the annotation.

Well, as a temporary measure we could probably just let them call it as a regular native query, no? That should work at least for stored procedures that return exactly one result set. WDYT?

gavinking avatar Mar 02 '21 18:03 gavinking

Well, as a temporary measure we could probably just let them call it as a regular native query, no?

Can't they just do that? They don't need to use @NamedStoredProcedure for it, isn't it?

DavideD avatar Mar 02 '21 19:03 DavideD

They can, I thought you were worried that they might be already using the @NamedStoredProcedure for that and didn't want to dupe it.

gavinking avatar Mar 02 '21 19:03 gavinking

Anyway, I propose that we just leave this issue open and unscheduled until someone asks for it.

gavinking avatar Mar 02 '21 19:03 gavinking

Sounds good to me

DavideD avatar Mar 02 '21 19:03 DavideD