hibernate-reactive icon indicating copy to clipboard operation
hibernate-reactive copied to clipboard

@Version @Source(DB)

Open DavideD opened this issue 3 years ago • 9 comments

@Version
@Source(SourceType.DB)
Date version

causes:

Caused by: java.sql.SQLException: Not using JDBC

It happens because, at some point, it calls org.hibernate.type.DbTimestampType.seed. I think we need a reactive version of it.

DavideD avatar Feb 24 '21 14:02 DavideD

Not sure if we need this for the first milestone

DavideD avatar Feb 24 '21 14:02 DavideD

It happens because, at some point, it calls org.hibernate.type.DbTimestampType.seed.

I think there's some other missing code for database-generated versions actually. (Noticed earlier today.)

gavinking avatar Feb 24 '21 14:02 gavinking

(So it's not so much a bug, just that we don't support the @Source annotation currently.)

gavinking avatar Feb 24 '21 14:02 gavinking

I think there's some other missing code for database-generated versions actually. (Noticed earlier today.)

I thought I caught them with that UnsupportedException I left but it seems it was a wrong assumption.

DavideD avatar Feb 24 '21 14:02 DavideD

I thought I caught them with that UnsupportedException I left but it seems it was a wrong assumption.

Apparently.

I say we document this as a limitation and leave it for after 1.0.

gavinking avatar Feb 24 '21 15:02 gavinking

(Unless you think it's like really easy to fix.)

gavinking avatar Feb 24 '21 15:02 gavinking

I have no idea and we have some other things already. I'm fine to leave it for after and include it if we find the time.

DavideD avatar Feb 24 '21 15:02 DavideD

I have no idea and we have some other things already.

I suspect this might be complicated because it deals with an ORM type and I'm not sure how much work it takes to have a reactive version of that chain of calls.

DavideD avatar Feb 24 '21 15:02 DavideD

I suspect this might be complicated because it deals with an ORM type and I'm not sure how much work it takes to have a reactive version of that chain of calls.

Fine. I'm certain it's not critical.

gavinking avatar Feb 24 '21 15:02 gavinking