hibernate-reactive
hibernate-reactive copied to clipboard
hibernate
Enable reproducible archives
fixes https://github.com/hibernate/hibernate-reactive/issues/1929
Hey @DavideD 😃, I thought while I was at it for ORM, I might as well see about Reactive.... It seems that the only thing for Reactive was to enable those two bool flags as nothing else was detected by the check. Now as for the check to make sure we don't break something along the way ... for Search/Validator and ORM I've added a check in the nightly builds, not sure about Reactive as most of the things are done with GH actions here... How would you want to handle that? (A Validator example https://ci.hibernate.org/blue/organizations/jenkins/hibernate-validator-nightly/detail/main/46/pipeline)
Also... to double check... Reactive produces only one jar (hibernate-reactive-core), right? Here's the result I get from the check:
ok=4
ko=0
okFiles="hibernate-reactive-core-2.4.1-SNAPSHOT.jar hibernate-reactive-core-2.4.1-SNAPSHOT.module hibernate-reactive-core-2.4.1-SNAPSHOT.pom hibernate-reactive-core-2.4.1-SNAPSHOT-sources.jar"
koFiles=""
Thanks. I'm a bit late on this but I'm going to have a look at it soon.
By the way, you left ORM in the comments, but I'm assuming it should be `Reactive
right ... fixed the comments 🙈 sorry Let me know if you want the check to run on Jenkins or as GH actions ... 😃
it's been a while 😄 I noticed this one while going through the list of my PRs 🙈 I've added a Jenkins job similar to the one we have for Search/Validator/ORM to test the build reproducibility in a nightly build. A test run against my repo for this job is here https://ci.hibernate.org/view/Personal%20jobs/job/hibernate-reactive-personal-marko/job/build%252Freprod-test/2/console
Any particular reason for this to be still a draft?
for Search/Validator and ORM I've added a check in the nightly builds, not sure about Reactive as most of the things are done with GH actions here
Hibernate Reactive also releases snapshots from CI now here: https://ci.hibernate.org/view/Reactive/job/hibernate-reactive-publish-snapshot/
Also... to double check... Reactive produces only one jar (hibernate-reactive-core), right?
Yes
Any particular reason for this to be still a draft?
Besides me not noticing it's still a draft, no, no other reason 😃 🙈
Hibernate Reactive also releases snapshots from CI now here: https://ci.hibernate.org/view/Reactive/job/hibernate-reactive-publish-snapshot/
nice 😃👍🏻, so adding another one to CI seems like a way to go.
nice 😃👍🏻, so adding another one to CI seems like a way to go.
Are you planning on doing it? Or should I merge this now and do it later? I'm assuming it will need this file updated: https://github.com/hibernate/hibernate-reactive/blob/main/ci/snapshot-publish.Jenkinsfile
Are you planning on doing it?
There's this new Jenkins file: ci/nightly/Jenkinsfile I think we shouldn't reuse the snapshot one, since it is supposed to use specific nodes to run on (see https://github.com/hibernate/hibernate-reactive/issues/2063 and PRs mentioned in it).
Usually, I would merge the Jenkins file and then create a job on CI, but let's try it the other way around.. I'll go create a placeholder for the nightly reactive job and then you can merge it whenever you would like 😃
Update: Link to the Reactive nightly: https://ci.hibernate.org/view/Reactive/job/hibernate-reactive-nightly/