hibernate-reactive icon indicating copy to clipboard operation
hibernate-reactive copied to clipboard

Published 20 hours ago • verified publisher icon hibernate

Test upsert with inheritance

Open DavideD opened this issue 2 years ago • 4 comments
trafficstars

We only test the upsert for ReactiveSingleTableEntityPersister, but it's also implemented for ReactiveUnionSubclassEntityPersister and ReactiveJoinedSubclassEntityPersister

We should also test the deletion of rows with upsert works (currently we only test the update) Related to issue #1702

DavideD avatar Sep 15 '23 15:09 DavideD

Hello,

I want to work on this issue. I found the UpsertTest.java class which contains the upsert tests already. I will check this class for a reference. But I didnt get exactly what do you mean here "deletion of rows with upsert works". Can you help me on this please.

firatulgay avatar Oct 31 '23 18:10 firatulgay

Hello, forget about the delete. When I created the issue I thought there was a way to also do that.

Thanks a lot for the offer.

If you create the test and it doesn't work, make sure to sync with @blafond before applying changes to the main code. He's working on something related to this.

As far as contribution guides, we use the same as the ORM one: https://github.com/hibernate/hibernate-orm/blob/main/CONTRIBUTING.md

Thanks a lot

DavideD avatar Oct 31 '23 19:10 DavideD