hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard
verified publisher icon hibernate

HHH-18132 Add support for skip locked for HANA

Open fmusolino opened this issue 1 year ago • 3 comments

https://hibernate.atlassian.net/browse/HHH-18132

fmusolino avatar May 17 '24 07:05 fmusolino

Corrected the issue with the string returned by getSkipLocked not containing the heading space and added an implementation for getForUpdateSkipLockedString in AbstractHANADialect. Still have to fix a problem with the version detection, so leaving this in draft for now.

fmusolino avatar May 17 '24 16:05 fmusolino

Hello there, I'm really sorry but I had some real life issues and I won't be be at my computer at least until tomorrow night, so I won't be able to make progress this weekend. I should be able to finish developing this on Monday tho.

fmusolino avatar May 18 '24 12:05 fmusolino

I fixed the issue with the version detection (which was caused by a misunderstanding of mine in how HANA version numbering works). My own tests had a positive result, so I'm putting this in ready for review.

fmusolino avatar May 20 '24 07:05 fmusolino

Will take a look at the failing tests as soon as I get home from work

fmusolino avatar May 21 '24 14:05 fmusolino

Don't worry about these test failures, those are different errors. Your PR is fine. Thanks.

beikov avatar May 21 '24 17:05 beikov

Thank you so much! It's actually my first time I submit a pull request for an open source project so I'm very glad this went smoothly. Thanks again.

fmusolino avatar May 21 '24 21:05 fmusolino

Thanks for your contribution. Looking forward to your next one ;)

beikov avatar May 23 '24 10:05 beikov