hibernate-orm
hibernate-orm copied to clipboard
Provide a way to override global env properties in a test ConnectionProviderBuilder
Hey 😃
We are using this ConnectionProviderBuilder in Search tests and in those cases, we usually have database settings coming from a Junit extension, which may be too late as Environment.getProperties() are already initialized. These changes would allow us to pass the settings from an extension into this builder.
Let me know if it makes sense to apply this, or if maybe you have other suggestions on how we can address the problem at hand 😃.
Thanks for your pull request!
This pull request does not follow the contribution rules. Could you have a look?
❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
↳ Offending commits: [e4712c4b3c475b5f03e576d9027fa7c9a86dc9c3]
› This message was automatically generated.
hi @beikov 😃 (since GH suggests I ping you for the review 😃 🙈) I was looking to see whether there was anything pending for Search as Steve was asking about 6.5 release, and I noticed this old PR. There's no urgency about this one; it would just be nice to get it in at some point so that we can remove the workaround in Search. Thanks!