hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

HHH-19841 test demoing bug in test or fix for HHH-11209

Open gavinking opened this issue 3 years ago • 5 comments

Either the test or the fix for HHH-11209 is bogus, because it leaves stuff hanging around in the action queue.

The test only passes by accident.

gavinking avatar Sep 24 '22 14:09 gavinking

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [d32efb926295dd329b7fb63d39c05c88f97fdd55] ❌ The pull request description must contain the license agreement text.     ↳ The description of this pull request must contain the following license agreement text:

----------------------
By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license](https://www.apache.org/licenses/LICENSE-2.0.txt)
and can be relicensed under the terms of the [LGPL v2.1 license](https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt) in the future at the maintainers' discretion.
For more information on licensing, please check [here](https://github.com/hibernate/hibernate-orm/blob/main/CONTRIBUTING.md#legal).

----------------------

› This message was automatically generated.

@gavinking This looks like something that should lead to reopening the issue or creating another one? Do you have more context?

yrodiere avatar Oct 06 '25 08:10 yrodiere

I found this context: https://github.com/hibernate/hibernate-orm/commit/17e8b727e9f01121f1c0b3f6dd982a6c7808ae03

It was merged as part of https://hibernate.atlassian.net/browse/HHH-15509 / https://github.com/hibernate/hibernate-orm/pull/5340

None of which seems directly related to https://hibernate.atlassian.net/browse/HHH-11209, so I assume the problem is still valid and should be filed/fixed.

yrodiere avatar Oct 06 '25 08:10 yrodiere

Should open an issue.

gavinking avatar Oct 06 '25 09:10 gavinking

Created https://hibernate.atlassian.net/browse/HHH-19841

yrodiere avatar Oct 06 '25 09:10 yrodiere