hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

Published 20 hours ago • verified publisher icon hibernate

Add missing blank in Dialect.cast SQL expression

Open urld opened this issue 3 years ago • 3 comments

The missing blank before 'as' resultet in an invalid SQL expression.

urld avatar Apr 28 '22 08:04 urld

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [ee0d0a6d16c087fb80de5a8c795f9f494e525ca0]

› This message was automatically generated.

hibernate-github-bot[bot] avatar Apr 28 '22 08:04 hibernate-github-bot[bot]

Hi @urld ,

can you please create a Jira ticket and if possible add to the PR a test case (it will be useful to prevent regressions).

Thanks

dreab8 avatar Apr 28 '22 08:04 dreab8

I understand the desire to fix this, but I just wanted to note that the only usages of this method are passing in Types.CHAR so the faulty branch will never be executed in regular Hibernate code. Only user code calling this method would run into the issue.

beikov avatar May 02 '22 11:05 beikov

Closing the PR now because it was stale for a while and the bug doesn't affect ORM code. You can create a new PR for a JIRA issue, after you created that, along with a test case.

beikov avatar Oct 04 '22 14:10 beikov