hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

Add support for week function in postgres

Open gcastill opened this issue 5 years ago • 2 comments

https://www.postgresql.org/docs/8.1/functions-datetime.html#FUNCTIONS-DATETIME-EXTRACT

gcastill avatar Nov 27 '20 15:11 gcastill

I'm not sure how I feel about this.

On the one hand, it does look like most of the other H5 dialects have a function named week(), though I don't remember whether they all have the same semantics.

On the other hand, should we perhaps just wait for H6, where we have already solved all these things in a totally disciplined and portable way, rather than just adding arbitrary things here and there in H5 without paying much attention to portability?

gavinking avatar Nov 27 '20 18:11 gavinking

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [df833d9d7f8ea87b743492e308151c7e21890ba0]

› This message was automatically generated.