HHH-19542 embeddable property order

[itsmoonrack]

https://hibernate.atlassian.net/browse/HHH-19542

The change is about using either the secondary table of a component, by looking at the first @Column available (to avoid nested component to be picked up), or fall-back on the property holder table if no secondary table is defined.

At first i tried to change the property order, which worked, but when doing the test against java record, it messed up the constructor order, so i had to find another strategy. Since we cannot change the property orders, the idea is to set the table directly on the component so we avoid changing it back in the ComponentPropertyHolder.

See jira for detailed analysis.

I am a bit concerned about naming convention in the lookup method getSecondaryTable if we have prefix, will it still work here ? Also for the lookup of secondary table best I could find was from the Column definition itself line 1011 of the EmbeddableBinder. Maybe there is a more direct route ?

I did not run the full test suit but only my two tests validate, I will let jenkins do the full suit.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion. For more information on licensing, please check here.

---

[itsmoonrack]

ok there is lot of tests failing due to this change, i'm working on fixing them

[itsmoonrack]

all tests are passing on local, would a maintainer accept the process in jenkins so it can run ?

[itsmoonrack]

What is the process now (this is my first contribution). Should I wait for a design review ? Do we just merge on master ? What if I want to backport this on the 6.x release lifecycle branches ?

Thank you for your time

[hibernate-github-bot[bot]]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[beikov]

Thanks for all the work you put in. While looking at your PR I figured that implicit table determination for columns in embeddables was a bit broken. I'm closing this PR in favor of a more streamlined fix https://github.com/hibernate/hibernate-orm/pull/10476