[HHH-19365] [WIP] GaussDB Dialect Support

[SweetWuXiaoMei]

HHH-19365 GaussDB Dialect Support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion. For more information on licensing, please check here.

---

[sebersole]

This should all be moved to the hibernate-community-dialects module rather than hibernate-core. Thanks!

Also, is this something you plan on testing continuously?

[SweetWuXiaoMei]

I noticed that there are still some dialect-related functions in the core module. Should I move all GaussDB dialect-related code into the hibernate-community-dialects module?

[liubao68]

This should all be moved to the hibernate-community-dialects module rather than hibernate-core. Thanks!

Also, is this something you plan on testing continuously?

We have read https://github.com/hibernate/hibernate-orm/blob/main/dialects.adoc and plan to contribute this dialect into core. Do you have any suggestions for contributing to core ? Do we need to contribute to hibernate-community-dialects first and move to core when everything is ok?

[sebersole]

I noticed that there are still some dialect-related functions in the core module. Should I move all GaussDB dialect-related code into the hibernate-community-dialects module?

Correct. All of the GaussDBDialect-related code you added here should be moved there.

[sebersole]

This should all be moved to the hibernate-community-dialects module rather than hibernate-core. Thanks! Also, is this something you plan on testing continuously?

We have read https://github.com/hibernate/hibernate-orm/blob/main/dialects.adoc and plan to contribute this dialect into core. Do you have any suggestions for contributing to core ? Do we need to contribute to hibernate-community-dialects first and move to core when everything is ok?

We have very strict standards for when Dialects get moved into hibernate-core.

For now (at least, though no promises at all), this is a community contributed and maintained Dialect, by definition. We (the Hibernate team) do not test it and won't support it per-se beyond keeping it up-to-date with changes we make to Dialect contracts.

[hibernate-github-bot[bot]]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[liubao68]

This should all be moved to the hibernate-community-dialects module rather than hibernate-core. Thanks! Also, is this something you plan on testing continuously?

We have read https://github.com/hibernate/hibernate-orm/blob/main/dialects.adoc and plan to contribute this dialect into core. Do you have any suggestions for contributing to core ? Do we need to contribute to hibernate-community-dialects first and move to core when everything is ok?

We have very strict standards for when Dialects get moved into hibernate-core.

For now (at least, though no promises at all), this is a community contributed and maintained Dialect, by definition. We (the Hibernate team) do not test it and won't support it per-se beyond keeping it up-to-date with changes we make to Dialect contracts.

we analyzed the differences between hibernate-core and hibernate-community. There is a relatively big gap in the quality assurance measures of the two. The code in hibernate-community will not execute the core test cases of hibernate-core. Ensuring that all the test cases provided by hibernate-core pass is of great importance for the quality. We expect that GaussDB can continuously pass all the test cases. What suggestions do you have regarding this situation? We are willing to provide relevant measures according to your requirements to ensure that the strict requirements of the hibernate community are complied with.

[yrodiere]

This should all be moved to the hibernate-community-dialects module rather than hibernate-core. Thanks! Also, is this something you plan on testing continuously?

We have read https://github.com/hibernate/hibernate-orm/blob/main/dialects.adoc and plan to contribute this dialect into core. Do you have any suggestions for contributing to core ? Do we need to contribute to hibernate-community-dialects first and move to core when everything is ok?

We have very strict standards for when Dialects get moved into hibernate-core. For now (at least, though no promises at all), this is a community contributed and maintained Dialect, by definition. We (the Hibernate team) do not test it and won't support it per-se beyond keeping it up-to-date with changes we make to Dialect contracts.

we analyzed the differences between hibernate-core and hibernate-community. There is a relatively big gap in the quality assurance measures of the two. The code in hibernate-community will not execute the core test cases of hibernate-core. Ensuring that all the test cases provided by hibernate-core pass is of great importance for the quality. We expect that GaussDB can continuously pass all the test cases. What suggestions do you have regarding this situation? We are willing to provide relevant measures according to your requirements to ensure that the strict requirements of the hibernate community are complied with.

We should probably continue this discussion on Zulip? https://hibernate.zulipchat.com/#narrow/channel/132096-hibernate-user/topic/GaussDB.20Dialect.20Support.20-.20PR.20.2319365

[liubao68]

We fixed all problems in this PR and add more feartures and improvements and created a new PR in https://github.com/hibernate/hibernate-orm/pull/10093

[beikov]

Closing in favor of https://github.com/hibernate/hibernate-orm/pull/10093