Archery icon indicating copy to clipboard operation
Archery copied to clipboard

fix connction function to newer pymongo

Open te87037 opened this issue 1 year ago • 5 comments

修正新版mongo的連線認證方式

te87037 avatar Jul 31 '24 06:07 te87037

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (83c9664) to head (24a31f5). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
sql/engines/mongo.py 66.66% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2747   +/-   ##
=======================================
  Coverage   77.85%   77.85%           
=======================================
  Files         122      122           
  Lines       16892    16893    +1     
=======================================
+ Hits        13151    13152    +1     
  Misses       3741     3741           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 31 '24 06:07 codecov[bot]

谢谢你的 pr, 整个 pr 是符合我要求的, 测试覆盖率也还可以, 逻辑没有问题, 但是这个覆盖率要求比较死, 麻烦你能不能给这个mongo engine 随意补充一点点测试, 大致写 10-20 行的有意义的测试, 这也总体的覆盖率就会上升, 我就可以merge 你的 pr 了

LeoQuote avatar Jul 31 '24 07:07 LeoQuote

谢谢你的 pr, 整个 pr 是符合我要求的, 测试覆盖率也还可以, 逻辑没有问题, 但是这个覆盖率要求比较死, 麻烦你能不能给这个mongo engine 随意补充一点点测试, 大致写 10-20 行的有意义的测试, 这也总体的覆盖率就会上升, 我就可以merge 你的 pr 了

我不太會撰寫測試,我應該去哪邊增加呢?

te87037 avatar Jul 31 '24 08:07 te87037

https://app.codecov.io/gh/hhyo/Archery/pull/2747/blob/sql/engines/mongo.py 你可以参考这里的报告, 红色是没有测试覆盖, 绿色是有测试覆盖, 你随意找一些方法, 针对这些方法写一下测试就可以了

关于测试可以看这里的文档, https://github.com/hhyo/Archery/wiki/development#%E5%8D%95%E5%85%83%E6%B5%8B%E8%AF%95

LeoQuote avatar Jul 31 '24 09:07 LeoQuote

我測試之後,發現在實例列表中測試連線時會完全沒辦法跳出相關訊息 需要再確認一下狀況

te87037 avatar Aug 12 '24 08:08 te87037

resolved by #2760

LeoQuote avatar Sep 03 '24 08:09 LeoQuote