Archery icon indicating copy to clipboard operation
Archery copied to clipboard

SQL检测和提交接入api方法

Open hhyo opened this issue 2 years ago • 2 comments

  1. 将SQL检测和提交接入api方法,废弃原有实现
  2. ExecuteCheck、WorkflowList两个视图权限替换为 permissions.IsAuthenticated,并增加单独的操作权限校验
  3. SQL工单列表和提交增加权限资源权限校验,只能操作有权限的资源

hhyo avatar Jul 09 '22 12:07 hhyo

Codecov Report

Base: 76.21% // Head: 76.10% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (ac8c7e6) compared to base (0977504). Patch coverage: 84.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
- Coverage   76.21%   76.10%   -0.12%     
==========================================
  Files          91       91              
  Lines       14319    14181     -138     
==========================================
- Hits        10913    10792     -121     
+ Misses       3406     3389      -17     
Impacted Files Coverage Δ
sql/sql_workflow.py 62.23% <ø> (-5.85%) :arrow_down:
sql/tests.py 98.87% <ø> (-0.08%) :arrow_down:
sql/urls.py 100.00% <ø> (ø)
sql/views.py 63.45% <ø> (-0.91%) :arrow_down:
sql_api/api_workflow.py 69.26% <71.42%> (+3.74%) :arrow_up:
sql_api/serializers.py 80.05% <76.92%> (+0.95%) :arrow_up:
sql/models.py 96.57% <100.00%> (ø)
sql_api/tests.py 100.00% <100.00%> (ø)
sql/engines/goinception.py 65.55% <0.00%> (-0.33%) :arrow_down:
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 10 '22 00:07 codecov[bot]

api部分的测试好像少了点啊🤔,看能不能按CI的提示补一补

LeoQuote avatar Jul 28 '22 00:07 LeoQuote

  1. 将SQL检测和提交接入api方法,废弃原有实现
  2. ExecuteCheck、WorkflowList两个视图权限替换为 permissions.IsAuthenticated,并增加单独的操作权限校验
  3. SQL工单列表和提交增加权限资源权限校验,只能操作有权限的资源

v1.9.0添加pr master分支login页面不正常,看diss https://github.com/hhyo/Archery/discussions/1822

bardyang avatar Sep 07 '22 07:09 bardyang