packaging icon indicating copy to clipboard operation
packaging copied to clipboard

Published 20 hours ago • verified publisher icon hhvm

Apply patches/ before creating source tarball, and remove

Open fredemmott opened this issue 6 years ago • 2 comments

Not doing this immediately to minimize changes while fixing debian-8-jessie

fredemmott avatar Aug 23 '19 16:08 fredemmott

should we do this now?

jjergus avatar Oct 25 '19 21:10 jjergus

this would still be good, but low-impact...

... on the other hand, if we're patching the source tarballs, it could be a good way to inject the HSL and somewhat higher impact :)

Problem there is testing changes to the HSL itself; HHVM has mechanisms for this (runtime-optional-extensions), but i think we'd need something like __PHPStdLib, but for the HSL, to make the HHIs work

fredemmott avatar Oct 29 '19 01:10 fredemmott