hhvm
Add HHClientLinter to NON_DEFAULT_LINTERS
The change looks good, but I think we should run it on some projects - both ours, and others - first.
This is a lot of linters to enable in one go, and we should try to get some more signal on if this is currently a good configuration.
This also ties into #287 a bit: linter inclusion in general, 'all', and 'default' is not a good categorization system.
What do you think about leaving this PR for now, instead:
- finish the other todos on https://github.com/hhvm/hhast/projects/1
- leaving it for an explicit opt-in
- ... but make a new release that supports the opt-in, announce on hhvm.com/blog/ , with details on configuration and asking for feedback?
Hi @Atry!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
