Results 508 comments of hhugo

``` let rec token buf = match%sedlex buf with | (Plus "a" as a), (Plus "b" as b), "c" -> ignore a; ignore b; Printf.printf "Op %s - %s\n" (Sedlexing.Latin1.sub_lexeme...

I think I would be easier if your trace was maintaining pairs of pos, instead of pos + len.

I would be useful to write test (as expect test (ppx_expect) maybe). The examples are currently not testing enough.

Another one ``` let print_alias buf name (x,len) = Printf.printf "%s: %S (%d, %d)\n" name (Sedlexing.Latin1.sub_lexeme buf x len) x len let rec token buf = match%sedlex buf with |...

I suspect you will need to track more than a pair of pos for some alias.

I think you should look at minimizing the quantity of code generated for trace fonctions. My last example generate a trace function with 80 cases. Have you though about optimizing...

This PR starts to look good, thanks for all the changes. - I think it would be nice to commit the post-processed version of your test (like you did before)...

You should also update the `README.md` with some documentation

> I think it would be nice to commit the post-processed version of your test (like you did before) with the corresponding dune stanza so that the file is kept...

I currently can't close/resolve threads. There are still a bunch unaddressed ones.