hhugo comments

Results 508 comments of


                                            hhugo

Difference patterns

Can someone close this ?

ppx in META prevents using sedlex in libraries

I think this should be closed

Nested matches using the same lexbuf produce misleading error

@toots, can you close this one. automatic closing didn't work

Should be possible to pass a sedlex regexp into a function, etc

I think this should either be closed or labelled as wont-fix

Buffer channel input, return None at the end of partial reads.

Running a quick benchmark, it seems that this PR is actually faster than the implementation on master, probably due to the fact that we perform less c calls. That said,...

Buffer channel input, return None at the end of partial reads.

Also, I think we would have invalid results if a give-back-control `None` was returned in the middle of Utf8.Helper.from_gen.

Buffer channel input, return None at the end of partial reads.

I have an alternative fix for #45, see #124

Buffer channel input, return None at the end of partial reads.

This can be closed @toots

Buffer channel input, return None at the end of partial reads.

I don't have other changes planned. I wanted to run some more tests with jsoo first maybe.

Buffer channel input, return None at the end of partial reads.

@toots, I run tests with jsoo, all good. I've just open one last fix #126