hhugo comments

Results 508 comments of


                                            hhugo

Use javascript string by default

I can help you if you need. Note that marshal on bytes will not work properly.

Use javascript string by default

https://github.com/jscoq/jscoq/blob/v8.11/coq-js/js_stub/str.js#L63 (`.c`) is possibly incorrect

Use javascript string by default

Rebased on top of the new Str support.

Use javascript string by default

> Does it mean that if I have a value of type string it is represented by a JavaScript string and I can give it to the DOM apis as...

Use javascript string by default

one more step, num will be compatible with that change https://github.com/ocaml/num/issues/21

Generalized program tree

Thanks. Would you mind restricting this PR To just introducing an additional IR. I don't want to review too many moving pieces at once.

Generalized program tree

I meant, restrict the PR to a new IR and plug it in - but exclude things that change the behavior

[BUG] js_of_ocaml-ppx doesn't emit sufficient locations for sourcemap.

I don't think jsoo debug info (js comments in the generated source) is relevant here. Are things working fine when not using separate compilation ? How do you know sourcemap...

[BUG] js_of_ocaml-ppx doesn't emit sufficient locations for sourcemap.

I'm not able to reproduce. Can you share the code and the dune file ?

[BUG] js_of_ocaml-ppx doesn't emit sufficient locations for sourcemap.

I don't think this has anything to do with separate compilation. It's rather related to the the ppx syntax extension and how it uses locations. Here is an extract of...