hh-histories-view-binding-migration-plugin icon indicating copy to clipboard operation
hh-histories-view-binding-migration-plugin copied to clipboard

After migration, missing viewBindingPlugin?

Open matthewmayer opened this issue 3 years ago • 3 comments

Nice idea for a plugin! I was dreading having to do this by hand for a large project.

I tried this out with a project, after migrating a file I get the error on

import ru.hh.shared.core.ui.framework.fragment_plugin.common.viewbinding.viewBindingPlugin

Is it also necessary to add a library to get this plugin? If so what needs to be added to the dependencies in build.gradle?

matthewmayer avatar Feb 21 '22 04:02 matthewmayer

Hi @matthewmayer ! It's a really tricky question for us =)

This plugin was not supposed to be a union solution for every project, we made it just as an example of what you can do with IDE plugins. And we did it with our company's codebase in mind.

I can give you small gist with all required classes for viewBindingPlugin plugin implementation, but I'm afraid that you will find it not appropriate for your project.

P.S. There are some comments in Russian, but it should not be a problem.

P.P.S. Right now we have PR in progress that will expand our plugin with a more common solution for other projects.

PStrelchenko avatar Feb 21 '22 16:02 PStrelchenko

Ah thank you for the gist! I wasn't sure if I was missing something,

I will take a look at the PR too and maybe I can help out improving the plugin and documentation after implementing on our codebase, to make it more generic. I think there will be a lot of developers in this position now that Google have announced an EOL date for Kotlin synthetics https://android-developers.googleblog.com/2022/02/discontinuing-kotlin-synthetics-for-views.html?m=1 so this could definitely be a good starting point for a community tool.

matthewmayer avatar Feb 21 '22 17:02 matthewmayer

It will be great, thank you 🙏

PStrelchenko avatar Feb 22 '22 07:02 PStrelchenko