EA-SVC icon indicating copy to clipboard operation
EA-SVC copied to clipboard

Unused parameters bug in configs

Open SolomidHero opened this issue 5 years ago • 2 comments

In configs there are stage parameter in each config with value 0, 1, 2. It is not used in the main train function of train.py file, but also fails with any command:

CUDA_VISIBLE_DEVICES=0 python train.py -c configs/stage1.json

with traceback:

Traceback (most recent call last):
  File "train.py", line 283, in <module>
    train(num_gpus, args.rank, args.group_name, **train_config)
TypeError: train() got an unexpected keyword argument 'stage'

SolomidHero avatar Jan 07 '21 14:01 SolomidHero

Also there are other parameters in configs for stage 2 and 3 that don't make sense in addition to stage, such as mu_quantization, filter_length, win_length and sp_dir.

Also, in stage1 there should be discriminator config defined too, otherwise error for stage 1 training.

And the last one problem: adv_ag and adv_fd should be specified

SolomidHero avatar Jan 18 '21 00:01 SolomidHero

Thanks for your comments. I will fix them in the next version.

hhguo avatar Jan 26 '21 09:01 hhguo