spree-ember icon indicating copy to clipboard operation
spree-ember copied to clipboard

Published 20 hours ago • verified publisher icon hhff

1.13

Open givanse opened this issue 9 years ago • 12 comments

I'm still working on changes for the other addons, but I figured that it would be good to start pushing as I have them ready so I can have early feedback.

This PR upgrades the addons to ember-cli 1.13.1, but keeps ember 0.12.0 and ember-data 1.0.0-beta.18. The changes pave the way towards 2.0.

core

default: PASS ember-1.13.0: PASS ember-ember-data-1.13.0: FAIL ember-release: PASS ember-beta: FAIL ember-canary: FAIL

storefront

default: PASS ember-1.13.0: PASS ember-ember-data-1.13.0: FAIL ember-release: PASS ember-beta: FAIL ember-canary: FAIL

auth

default: PASS ember-1.13.0: FAIL ember-ember-data-1.13.0: FAIL ember-release: FAIL ember-beta: FAIL ember-canary: FAIL

checkouts

default: PASS ember-1.13.0: PASS ember-ember-data-1.13.0: FAIL ember-release: PASS ember-beta: FAIL ember-canary: FAIL

givanse avatar Jul 13 '15 01:07 givanse

~~Will ember-1.11.0 be supported? I don't see a strong reason for that.~~ According to npm spree-ember 0.0.1-beta.1 was released almost at the same time of the release of ember v1.12.0, so nobody was using it with 1.11. I'll delete those configs.

givanse avatar Jul 13 '15 04:07 givanse

Yo @givanse you're the fucking MAN

Comments coming shortly

hhff avatar Jul 13 '15 07:07 hhff

Only auth has failing tests for 1.13.0. It eludes me at the moment and right now I need to get other stuff done :/

Is the upgrade to ember-simple-auth 0.8.0 done? or half way there? Just noticed the version number in package.json, but there is also an open issue about it.

givanse avatar Jul 13 '15 09:07 givanse

I'll have a look at Auth!

Just haven't got around to bumping the version of simple auth yet - it was in beta when 0.0.1 was released

hhff avatar Jul 13 '15 09:07 hhff

@givanse - I should have time to work on this this week - can I have push for your fork? I'll do all my work on this branch

hhff avatar Sep 01 '15 13:09 hhff

@hhff Yes, added you.

givanse avatar Sep 01 '15 14:09 givanse

thanks @givanse !

hhff avatar Sep 01 '15 15:09 hhff

@hhff Did you update the backend that is used when the tests are run? (http://testing.spree-ember.com)

givanse avatar Sep 26 '15 19:09 givanse

@givanse - I haven't - it's been the same for a while. Does it need a change?

hhff avatar Sep 28 '15 15:09 hhff

Some tests that were ok before are failing now. Simple things like:

was expecting 'Bags'
actual result 'Mugs'

Maybe a sorting change in the taxons? I fixed (edited for Mugs) and four more errors appeared. Maybe the seed data was edited?

I didn't spend much time looking into this, decided to wait for a reply. If nothing has changed, I'll check what is going on.

givanse avatar Sep 28 '15 17:09 givanse

yeah i haven't changed it at all - but I'm guessing it's just an ordering thing - so if the tests explicitly "clicked" the mugs label rather than the first item, we should be cool

hhff avatar Sep 28 '15 17:09 hhff

thank you so so much for working on this @givanse u are the mannnnn

hhff avatar Sep 28 '15 17:09 hhff