CatFactory.EntityFrameworkCore icon indicating copy to clipboard operation
CatFactory.EntityFrameworkCore copied to clipboard
verified publisher icon hherzl

Scalar function parameters use incorrect naming convention

Open glacasa opened this issue 5 years ago • 2 comments

When we add the scalar functions to the DbContext, the parameters name use project.GetPropertyName(parameter) instead of project.GetParameterName(parameter)

https://github.com/hherzl/CatFactory.EntityFrameworkCore/blob/209d2b48e71c647bd82bba639184c9c5807d54ba/CatFactory.EntityFrameworkCore/Definitions/Extensions/DbContextClassBuilder.cs#L186

glacasa avatar Sep 25 '20 22:09 glacasa

There is a new version that solves this issue, please use the following version: 1.0.0-beta-sun-build51

hherzl avatar Sep 27 '20 21:09 hherzl

At first I thought it didn't work, but it seems ok.

When calling DotNetNamingConvention.GetParameterName(value), il value starts with an uppercase, it returns a lowercase. But when it starts with @, the first letter is uppercase.

But now I can override this in my custom ICodeNamingConvention, so it's fine

glacasa avatar Sep 28 '20 08:09 glacasa