node-ddp-client icon indicating copy to clipboard operation
node-ddp-client copied to clipboard

(feat) adds promisified constructor, fixes #10 and #11, bumps minor version

Open sunny-g opened this issue 9 years ago • 4 comments

In reference to #10 and #11, this restores the observer methods added, changed and removed to the observer object and calls them when handling their corresponding DDP messages.

This also fixes a mismatch between the naming convention changed and updated that wasn't resolved in #11; the observer now has a method changed by default that is called when receiving DDP messages of the type "changed".

sunny-g avatar Oct 17 '15 18:10 sunny-g

LGTM

codydaig avatar Oct 17 '15 22:10 codydaig

Closing because I see why you made the changes (minimongo lets us observe collections rather than directly observing stored data from subscriptions).

sunny-g avatar Nov 10 '15 22:11 sunny-g

I've removed the observers since they can't be used, regardless of maintainCollections, and added another class DDP that is the same but with Promise-ified versions of all of the asynchronous functions.

There may have been a thing or two I've forgotten so let me know if there are any changes you want me to make.

sunny-g avatar Nov 11 '15 03:11 sunny-g

+1

yogiben avatar Jan 11 '16 13:01 yogiben