CleanCode icon indicating copy to clipboard operation
CleanCode copied to clipboard

It seems the "method too long" restriction isn't counting the statements correctly

Open SuperJMN opened this issue 7 years ago • 1 comments

The advice is triggered in some methods that are smaller than specified number of lines.

SuperJMN avatar Apr 13 '17 11:04 SuperJMN

I noticed that a single-line if statement counts as 2, but if I put that inside braces, the same statement counts as 3. It's bad practice to use single-line if statements, so should the braces be counted as a statement?

Also, the following code evaluates to 5 statements. Is it the declaration, the if, the comparison, and the two return statements?

int i = 1;
if (i == 1) return "hey";
return "uhoh";

nhamlin-mw avatar Jun 05 '18 20:06 nhamlin-mw