play2-scala-pdf icon indicating copy to clipboard operation
play2-scala-pdf copied to clipboard

flyingsaucer update 9.1.18

Open avp90 opened this issue 5 years ago • 4 comments

Hi, i would like to use the library (with Play 2.6 and scala 2.11) for creating PDFs. Unfortunately there is still a bug with box sizing which should be fixed with the flyingsaucer v9.1.18 release. Can you update the version?

avp90 avatar Jun 04 '19 08:06 avp90

I have tried to update the version but i get the following error: java.lang.NoClassDefFoundError: com/twelvemonkeys/imageio/spi/ImageWriterSpiBase

After a little search i found your comment in build.sbt#L61. I removed % Test in build.sbt#L62 and now it is runnable.

avp90 avatar Jun 06 '19 09:06 avp90

Hi @avp90 , is this issue still relevant? i.e. can I close it.

Two things though:

  1. I'm still planning to update FlyingSaucer to latest version, but I think it is not related to the issues you're experiencing, is that correct?
  2. Seems like ImageWriterSpiBase is a required dependency somewhat. Perhaps I can update build.sbt in the library to include this as a dependency (instead just for Test right now).

hhandoko avatar Aug 18 '19 01:08 hhandoko

Hi @hhandoko, the issue is still relevant until flyingsaucer v9.1.18 is used. In the master Branch is Version 9.1.14 active: "org.xhtmlrenderer" % "flying-saucer-pdf-openpdf" % "9.1.14"

ImageWriterSpiBase seems to be a required dependency of v9.1.18.

avp90 avatar Aug 18 '19 05:08 avp90

Some tests are failing when updated to 9.1.18, which I experienced before. I think this is due to some font-loading issue. I'll raise a PR once I found a solution.

hhandoko avatar Aug 18 '19 08:08 hhandoko