Philip Wedemann

Results 247 comments of Philip Wedemann

There is a problem with the url though: the official urls are often just a template. For a valid license, you need to adopt the owner and year. At least...

I don't know because I can only get the latest json but let's remove it and see it next update, and add it if needed.

Yes, exposing the collections would be my favorite design too, but what about `allowedUrls`, `allowedDependencies` and `ignoredDependencies`? ```kotlin // kotlin licensee { val allowed: SetProperty allowed.add(SpdxId.MIT) val allowedUrls: NamedDomainObjectContainer allowedUrls.register("https://example.com/license.html")...

Yes, I did but you can't override `valueOf` using the `id` and having `valueOf` and `getById` is confusing IMHO. I am okay with both.

What's wrong with the 5316 lines of code? :D

The S3 link is dead, do you know if we should use this link instead? https://api.opensource.org/licenses/

Do you mean, you want to put the content of the `artifacts.json` in the `spdx.json`? The spdx spec is a superset of the current `artifacts.json` file. It includes everything of...

Sure, have `fun` too :D

While I think, this is an upstream issue, I fixed this in #189. Just curious, how do you use licensee? KGP does not support 8.1 yet.

@JakeWharton Do you accept a PR or are you still not convinced?