openmoji icon indicating copy to clipboard operation
openmoji copied to clipboard

Published 20 hours ago • verified publisher icon hfg-gmuend

kirylchyk_added_flag_emoji_washingtonDC

Open Kirylchyk opened this issue 1 year ago • 1 comments

As per opened enhancement ticket https://github.com/hfg-gmuend/openmoji/issues/467, adding a new emoji for Washington DC flag

Kirylchyk avatar Feb 07 '24 18:02 Kirylchyk

Many thanks for this! But please change the aspect ration following the other flags. Also make sure that running npm run test-dev produces no errors, currently this is not the case.

b-g avatar Feb 19 '24 15:02 b-g

Modified aspect ration and ran npm run test-dev. Got 55585 passing, 1 failed due to hexcode, but i think it's not an issue as I am adding non-standard emoji.

Thank you

Kirylchyk avatar Feb 21 '24 19:02 Kirylchyk

Many thanks for the improvements! Close :) The stars seem to be distorted e.g. could you please fix them e.g. compare with https://en.wikipedia.org/wiki/Flag_of_Washington,_D.C. and the images below? Other than that, I think we are ready to merge.

2024-02-22 at 12 22

Screen Shot 2024-02-22 at 12 23 10

PS: I've fixed the hexcode issue, npm run test-dev is green now.

b-g avatar Feb 22 '24 12:02 b-g

Thank you for your feedback. Sending the latest version for the approval.

Kirylchyk avatar Feb 22 '24 19:02 Kirylchyk

Many thanks! Merged.

b-g avatar Feb 23 '24 07:02 b-g

Thank you for your cooperation!

Kirylchyk avatar Feb 25 '24 22:02 Kirylchyk