slack-export-viewer icon indicating copy to clipboard operation
slack-export-viewer copied to clipboard

Upload zip to server

Open tscritch opened this issue 6 years ago • 2 comments

Change Reader object to store all of the data instead of returning it from the compile functions Change app routes to use reader values Add upload view to upload a zip file Some tech debt:

  • if the --no-browser is set then the app will go to the upload view. for the CLI we want it to go directly to the /channels url
  • the archives directory needs to be wiped on the server every time a new zip is uploaded

tscritch avatar May 04 '18 01:05 tscritch

Hey @hfaran just mostly wanted to show you what I worked on. I had to get this out this week for my work. I can fix all of this stuff. What do you think about the implementation?

tscritch avatar May 04 '18 21:05 tscritch

Hey @hfaran just mostly wanted to show you what I worked on. I had to get this out this week for my work. I can fix all of this stuff. What do you think about the implementation?

Well, as long as:

  • it works
  • is mostly bug-free
  • you resolve all of the comments I had

implementation looks fine to me. :+1: 😄

hfaran avatar May 04 '18 21:05 hfaran