hey icon indicating copy to clipboard operation
hey copied to clipboard

Add skeleton loader for loading images

Open bigint opened this issue 3 years ago • 3 comments

bigint avatar Jul 20 '22 17:07 bigint

@bigint What images (in what page or location) does this refer to? For images in posts, there is a grey background before the images has loaded, which looks OK in my opinion. On the NFT page for a user, there's already a skeleton loader. Is there some other place that needs skeleton loader?

foolo avatar Dec 12 '22 19:12 foolo

Hi @bigint please assign me to this task :)

richardgreg avatar Feb 24 '23 10:02 richardgreg

@richardgreg assigned 🚀

bigint avatar Mar 18 '23 17:03 bigint

@bigint please assign me this task for submission. i was the one that did it on dework and you said i should have a PR repo for re submission.

Creed1732 avatar Apr 04 '23 23:04 Creed1732

@Creed1732 Sure, go ahead and work on it. Though it seems lenster already has the skeleton loader feature. Or am I missing something?

richardgreg avatar Apr 06 '23 04:04 richardgreg

yea, they have that already...but not for the images...btw are you a moderator?.... just asking...

Creed1732 avatar Apr 06 '23 16:04 Creed1732

No, a contributor

richardgreg avatar Apr 06 '23 17:04 richardgreg

I already did the task, just waiting to get assigned so i'll make submissions @richardgreg

Creed1732 avatar Apr 07 '23 16:04 Creed1732

@Creed1732 assigned

bigint avatar Apr 07 '23 18:04 bigint

@bigint check submission

Creed1732 avatar Apr 12 '23 23:04 Creed1732

@Creed1732 where is the PR?

bigint avatar Apr 13 '23 05:04 bigint

Hi @bigint, had a quick look at this. Which images would we be trying to add a loading shimmer to? As far as I can see, in publications, the PublicationPageShimmer would cover the whole post including the image in the post and the rest seem to be covered as mentioned here, https://github.com/lensterxyz/lenster/issues/59#issuecomment-1347188752. Could you please clarify on how this would be handled?

brymut avatar Apr 13 '23 13:04 brymut

I could not find #59 where i was to compare branches

Creed1732 avatar Apr 14 '23 02:04 Creed1732

is the issue open rn? would like to work on it

Sahil-B07 avatar Oct 30 '23 09:10 Sahil-B07

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

github-actions[bot] avatar Jan 07 '24 13:01 github-actions[bot]