hey icon indicating copy to clipboard operation
hey copied to clipboard

[Enhancement] Hide communities from top collected

Open bigint opened this issue 2 years ago • 5 comments

bigint avatar Jul 20 '22 17:07 bigint

@bigint 👋

ready to pick it up

In general, I am a little bit familiar with Lens documentation, but if this issue has something specific for implementation - let me know :)

As I understand, I need to hide those community mentions(the issue name is self-explanatory) image

andriishupta avatar Aug 09 '22 09:08 andriishupta

Exactly we need to hide all those community launches from the Top collected section 🙇🏼

bigint avatar Aug 09 '22 09:08 bigint

cool, so I would start and come back with PR when I would have something - should be today 📆

andriishupta avatar Aug 09 '22 09:08 andriishupta

@bigint, please, check PR #344

copying what I did in PR here as a message

followed API and added sources TOP_COLLECTED Feed https://docs.lens.xyz/docs/explore-publications#request

as side changes:

  • I added .gitignore for .idea - would be common for future contributors who uses Webstorm
  • I fixed the startup issue with mixpanel.ts
  • I added lensterCommunity app to keep reference that it exists

andriishupta avatar Aug 09 '22 12:08 andriishupta

Also, tested - works as expected:

  • go to Explore -> default Top Commented -> with communities and no sources in the payload
  • go to Top Collected -> NO communities, and there are sources in the payload
  • go back to Top Commented -> cached results
  • scroll down - new query without sources for Top Commented with communities in results

andriishupta avatar Aug 09 '22 12:08 andriishupta

Communities are no more 👋🏼

bigint avatar Aug 26 '22 13:08 bigint

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

github-actions[bot] avatar Jan 07 '24 15:01 github-actions[bot]