hey icon indicating copy to clipboard operation
hey copied to clipboard

fix: JS-0746 rule - prefer to accompany onClick with some elements

Open piraces opened this issue 1 year ago • 6 comments

What does this PR do?

Fixes #114

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Enhancement (non-breaking small changes to existing functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How should this be tested?

n/a. Non breaking changes. Only accompany onClick handling with onKeyDown for accesibility reasons.

Checklist

piraces avatar Nov 15 '22 21:11 piraces

@piraces is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 15 '22 21:11 vercel[bot]

Working on introduced issues in deepsource...

piraces avatar Nov 15 '22 21:11 piraces

Done! 😄

piraces avatar Nov 15 '22 22:11 piraces

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 7:47AM (UTC)

vercel[bot] avatar Nov 16 '22 07:11 vercel[bot]

We have migrated to monorepo, can you please sync with main branch 🙏🏼

bigint avatar Nov 20 '22 13:11 bigint

Done @bigint ! I have solved other "introduced" results that deepsource identified, resulting in a total of 165 resolved.

Edit: also two introduced issues about onClick without onKeyDown.

(P.S. the monorepo change its great! I have never tried turborepo and its very fast 👍 )

piraces avatar Nov 21 '22 15:11 piraces

This is not a high priority issue 🙇🏼

Closing this for now 🙏🏼

bigint avatar Dec 06 '22 14:12 bigint