hey
hey copied to clipboard
fix: JS-0746 rule - prefer to accompany onClick with some elements
What does this PR do?
Fixes #114
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Enhancement (non-breaking small changes to existing functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How should this be tested?
n/a. Non breaking changes. Only accompany onClick
handling with onKeyDown
for accesibility reasons.
Checklist
@piraces is attempting to deploy a commit to the Lenster Team on Vercel.
A member of the Team first needs to authorize it.
Working on introduced issues in deepsource...
Done! 😄
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
lenster | ✅ Ready (Inspect) | Visit Preview | Nov 16, 2022 at 7:47AM (UTC) |
We have migrated to monorepo, can you please sync with main
branch 🙏🏼
Done @bigint ! I have solved other "introduced" results that deepsource identified, resulting in a total of 165 resolved.
Edit: also two introduced issues about onClick without onKeyDown.
(P.S. the monorepo change its great! I have never tried turborepo and its very fast 👍 )
This is not a high priority issue 🙇🏼
Closing this for now 🙏🏼