hey icon indicating copy to clipboard operation
hey copied to clipboard

fix: JS-0295 rule //@ts-<directive> comments

Open piraces opened this issue 1 year ago • 2 comments

What does this PR do?

Fixes #116

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Enhancement (non-breaking small changes to existing functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How should this be tested?

n/a. Non breaking changes. Only typing.

Checklist

piraces avatar Nov 14 '22 22:11 piraces

@piraces is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 14 '22 22:11 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 1:15PM (UTC)
lenster ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 1:15PM (UTC)
web ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 1:15PM (UTC)

vercel[bot] avatar Nov 15 '22 00:11 vercel[bot]

Sorry for the review requests... I just tried to request review for all of you but it removes some requests... 😞 Nevertheless, all comments are resolved by now 👍

piraces avatar Nov 16 '22 19:11 piraces

Sorry for the review requests... I just tried to request review for all of you but it removes some requests... 😞 Nevertheless, all comments are resolved by now 👍

Hey, no worries

shanpriyan avatar Nov 17 '22 03:11 shanpriyan

We have migrated to monorepo, can you please sync with main branch 🙏🏼

bigint avatar Nov 20 '22 13:11 bigint

@bigint already rebased and solved all deepsource problems as the original conversations 👍

piraces avatar Nov 21 '22 17:11 piraces

Thanks for the PR we fixed this in https://github.com/lensterxyz/lenster/pull/1317 🙏🏼

bigint avatar Nov 27 '22 07:11 bigint